Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docs #352

Merged
merged 6 commits into from
May 28, 2018
Merged

update docs #352

merged 6 commits into from
May 28, 2018

Conversation

oskooi
Copy link
Collaborator

@oskooi oskooi commented May 22, 2018

Updates to the Tutorial/Basics example on Angular Reflectance Spectrum as well as Tutorial/Material Dispersion.

We will need to add a new test to the Python suite based on the recently-added example refl-angular.py which is updated in this PR.

@@ -99,6 +99,6 @@
plt.plot(wl,Ts,'ro-',label='transmittance')
plt.plot(wl,1-Rs-Ts,'go-',label='loss')
plt.axis([5.0, 10.0, 0, 1])
plt.xlabel("wavelength (um)")
plt.xlabel("wavelength (μm)")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unicode literals will break in Python 2. If you add this line to the top of the file:

# -*- coding: utf-8 -*-

then it should work in python 2 and 3.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion. Fixed.

@stevengj stevengj merged commit 8581823 into NanoComp:master May 28, 2018
@oskooi oskooi deleted the update_docs_may21 branch September 13, 2018 19:53
bencbartlett pushed a commit to bencbartlett/meep that referenced this pull request Sep 9, 2021
* update docs

* fixes

* tweaks

* more fixes

* more tweaks

* fix unicode literals for Python 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants